Skip to content

Fix SidePanelModals padding - #6062

Merged
rtibbles merged 1 commit into
learningequality:unstablefrom
AlexVelezLl:fix/channel-table-status-filter-reset
Aug 4, 2026
Merged

Fix SidePanelModals padding#6062
rtibbles merged 1 commit into
learningequality:unstablefrom
AlexVelezLl:fix/channel-table-status-filter-reset

Conversation

@AlexVelezLl

@AlexVelezLl AlexVelezLl commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary

  • Consumers of SidePanelModal lost their internal padding after a prior PR removed it from the shared component.

Reviewer guidance

  • Check side panel modals across Studio.
Before After
image image

@AlexVelezLl
AlexVelezLl marked this pull request as ready for review July 31, 2026 20:36
@AlexVelezLl
AlexVelezLl requested a review from marcellamaki July 31, 2026 20:37

@rtibbles rtibbles left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense, and the screenshots demonstrate them. Let's target to hotfixes for quicker release!

SidePanelModal no longer applies internal padding to its content, so
consumers that relied on it lost their spacing. Add the padding
directly in ReviewSubmissionSidePanel and CommunityLibraryFilters.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@AlexVelezLl
AlexVelezLl force-pushed the fix/channel-table-status-filter-reset branch from 9e354e2 to c80838f Compare August 3, 2026 12:52
@AlexVelezLl AlexVelezLl changed the title Miscellaneous UI fixes: channel table filter reset, SidePanelModal padding, status button width Fix SidePanelModals padding Aug 3, 2026
@AlexVelezLl

Copy link
Copy Markdown
Member Author

Hi @rtibbles! I forgot to consider opening these against hotfixes 😅. Just created a different PR for hotfixes and kept this for the side panel paddings (because this was only happening on unstable after a kds to studio PR).

@AlexVelezLl
AlexVelezLl requested a review from rtibbles August 3, 2026 12:56
@rtibbles
rtibbles merged commit 93d3acd into learningequality:unstable Aug 4, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants